feat: use react-unipika library #3186
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested review from
adameat,
artemmufazalov and
astandrik
as code owners
Contributor
Author
|
@greptile-review |
Raubzeug
force-pushed
the
react-unipika
branch
from
8b78d04 to
fb22b0d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates from a custom unipika implementation to the @gravity-ui/react-unipika library (v0.5.0), significantly simplifying the codebase by removing ~1000 lines of custom code. The migration affects the JsonViewer component and all its consumers across the application.
Key Changes:
- Replaced custom unipika implementation with
@gravity-ui/react-unipikalibrary - Refactored JsonViewer component to use ReactUnipika component as wrapper
- Added
scrollContainerRefprop to JsonViewer and threading it through component hierarchies
Reviewed changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added @gravity-ui/react-unipika v0.5.0 dependency |
| package-lock.json | Lock file update for new dependency |
| src/components/JsonViewer/JsonViewer.tsx | Major refactor to use ReactUnipika library, simplified from ~370 to ~140 lines |
| src/components/JsonViewer/JsonViewer.scss | Updated styles to work with library's class names (g-ru-cell) |
| src/components/JsonViewer/i18n/en.json | Removed unused i18n keys, added new error message key |
| src/components/JsonViewer/unipika/* | Deleted custom unipika implementation files (~500 lines) |
| src/components/JsonViewer/components/* | Deleted custom components replaced by library (Cell, ToggleCollapseButton, etc.) |
| src/components/JsonViewer/utils.ts | Deleted helper utilities no longer needed |
| src/containers/Tenant/Query/QueryResult/components/QueryJSONViewer/QueryJSONViewer.tsx | Added scrollRef for JsonViewer integration |
| src/containers/Tenant/Diagnostics/Describe/Describe.tsx | Passed scrollContainerRef to JsonViewer |
| src/containers/Tenant/Diagnostics/TopicData/* | Threading scrollContainerRef through TopicData component hierarchy |
| src/containers/Configs/components/Config/Config.tsx | Added wrapper structure and scrollContainerRef for JsonViewer |
| src/containers/Configs/components/Config/Config.scss | New styles for Config wrapper container |
| src/containers/Configs/Configs.scss | Removed unused CSS variable |
| src/containers/Tenant/Diagnostics/TopicData/FullValue.tsx | Deleted unused component |
src/containers/Tenant/Query/QueryResult/components/QueryJSONViewer/QueryJSONViewer.tsx
Outdated
Show resolved
Hide resolved
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
src/containers/Tenant/Diagnostics/TopicData/TopicMessageDetails/components/TopicMessage.tsx
Outdated
Show resolved
Hide resolved
Raubzeug
force-pushed
the
react-unipika
branch
from
7e7fc92 to
2830759
Compare
| "description_search": "Search...", | ||
| "description_matched-rows": "Matched rows", | ||
| "description_full-value": "Full value", | ||
| "context_case-sensitive-search": "Case sensitive search enadled", |
Contributor
There was a problem hiding this comment.
syntax: typo: "enadled" should be "enabled"
Suggested change
| "context_case-sensitive-search": "Case sensitive search enadled", | |
| "context_case-sensitive-search": "Case sensitive search enabled", |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/components/JsonViewer/i18n/en.json
Line: 8:8
Comment:
**syntax:** typo: "enadled" should be "enabled"
```suggestion
"context_case-sensitive-search": "Case sensitive search enabled",
```
How can I resolve this? If you propose a fix, please make it concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stand
closes #1952
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 62.48 MB | Main: 62.34 MB
Diff: +0.14 MB (0.23%)
ℹ️ CI Information