Add OpenTelemetry lib and metric-interfaces by maladetska · Pull Request #588 · ydb-platform/ydb-cpp-sdk

maladetska · 2026-02-07T12:58:13Z

No description provided.

include/ydb-cpp-sdk/client/metrics/metrics.h

github-actions · 2026-02-21T15:01:52Z

🌋 SLO Test Results

Status: 🟢 2 workloads tested • All passed

	Workload	Metrics	Regressions	Improvements	Links
🚀	table-clang	8	0	1	Report • Check
🚀	table-gcc	8	1	1	Report • Check

Generated by ydb-slo-action

cmake/external_libs.cmake

CMakeLists.txt

Gazizonoki

Мне кажется папка open_telemetry в корне не самая удобная штука. Это же плагин к sdk, может сделаем папку plugins(extensions или еще какое-то имя) и туда положим все такие штуки (экспортеры метрик, трейсов, логов для конкретных систем и т. д.)?

И с метриками, оно вообще используется по коду? SDK уже собирает много метрик, в задаче с метриками это и есть главная сложность, как аккуратно перевести все на общий интерфейс и выкинуть library/cpp/monlib уже к черту из внешнего репозитория (это так-то внутренняя штука, вылезла в open-source ydb-cpp-sdk из-за неаккуратности)

include/ydb-cpp-sdk/client/metrics/metrics.h

open_telemetry/CMakeLists.txt

open_telemetry/src/otel.cpp

plugins/open_telemetry/src/metrics.cpp

src/client/query/impl/query_spans.cpp

src/client/query/client.cpp

include/ydb-cpp-sdk/client/driver/driver.h

include/ydb-cpp-sdk/client/metrics/metrics.h

plugins/CMakeLists.txt

src/client/impl/internal/grpc_connections/grpc_connections.h

plugins/open_telemetry/include/ydb-cpp-sdk/open_telemetry/extension.h

plugins/open_telemetry/include/ydb-cpp-sdk/open_telemetry/metrics.h

plugins/open_telemetry/include/ydb-cpp-sdk/open_telemetry/trace.h

src/client/query/impl/query_spans.cpp

Gazizonoki

Было бы неплохо example с метриками завести еще

cmake/external_libs.cmake

include/ydb-cpp-sdk/client/trace/trace.h

plugins/trace/otel/include/ydb-cpp-sdk/open_telemetry/trace.h

src/client/query/impl/query_metrics.cpp

src/client/query/impl/query_spans.h

src/client/query/impl/query_metrics.h

src/client/query/impl/query_metrics.cpp

src/client/query/impl/query_spans.cpp

Gazizonoki

А что с stats.h будет?

cmake/external_libs.cmake

include/ydb-cpp-sdk/client/trace/trace.h

plugins/trace/otel/include/ydb-cpp-sdk/open_telemetry/trace.h

src/client/impl/observability/client_metrics.cpp

src/client/impl/observability/operation_metrics.cpp

src/client/impl/observability/operation_span.cpp

src/client/query/client.cpp

src/client/table/impl/table_client.cpp

src/client/impl/observability/operation_metrics.h

src/client/query/impl/query_spans.h

src/client/query/client.cpp

src/client/table/impl/table_client.cpp

src/client/impl/stats/stats.h

…an, remove TQuerySpan and TQueryMetrics, modify TClientOperationStatCollector constructor

…ion, other_sql -> ydb

src/client/impl/internal/common/ydb_client_api.h

src/client/impl/stats/stats.h

… make attributes freecase

KirillKurdyukov requested a review from Gazizonoki February 9, 2026 12:04

maladetska commented Feb 17, 2026

View reviewed changes

include/ydb-cpp-sdk/client/metrics/metrics.h Show resolved Hide resolved

init commit

a102d53

maladetska force-pushed the METRICS-0 branch from beec910 to a102d53 Compare February 17, 2026 10:43

.

9011838

make metrics as client_component

bbc803b

maladetska changed the title ~~init?~~ Add OpenTelemetry lib Feb 24, 2026

maladetska commented Feb 24, 2026

View reviewed changes

cmake/external_libs.cmake Outdated Show resolved Hide resolved

maladetska commented Feb 24, 2026

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

maladetska changed the title ~~Add OpenTelemetry lib~~ Add OpenTelemetry lib and metric-interfaces Feb 24, 2026

Gazizonoki requested changes Feb 24, 2026

View reviewed changes

maladetska added 2 commits March 1, 2026 02:20

fixes

feb3e8d

add includes

0e31bc1

Gazizonoki reviewed Mar 10, 2026

View reviewed changes

fixes and add metric tests

23414c1

Gazizonoki requested changes Mar 20, 2026

View reviewed changes

maladetska force-pushed the METRICS-0 branch 2 times, most recently from a0abdba to ec3df8e Compare March 24, 2026 13:02

KirillKurdyukov self-requested a review March 24, 2026 14:45

maladetska force-pushed the METRICS-0 branch 3 times, most recently from 4fec641 to a78a18b Compare March 27, 2026 19:21

add table metrics

aa80faa

maladetska force-pushed the METRICS-0 branch 2 times, most recently from 7cbed5c to 9c46b67 Compare March 29, 2026 22:39

fix semconv

b46d384

maladetska force-pushed the METRICS-0 branch from 4d0f63e to b46d384 Compare March 30, 2026 10:29

Gazizonoki requested changes Mar 30, 2026

View reviewed changes

maladetska force-pushed the METRICS-0 branch from 43f633c to 29936bc Compare March 31, 2026 16:28

fix namespaces, CMakeLists

fe6450e

maladetska force-pushed the METRICS-0 branch from c82e6a5 to fe6450e Compare March 31, 2026 16:30

maladetska added 2 commits April 1, 2026 14:11

unify client operation metrics pipeline

1071974

add cloned log_lazy

5e4ea26

maladetska force-pushed the METRICS-0 branch from 16cc5f7 to 5e4ea26 Compare April 1, 2026 12:54

fix SafeLogMetricsError, SafeLogSpanError

947b4ca

Gazizonoki reviewed Apr 1, 2026

View reviewed changes

maladetska added 3 commits April 2, 2026 10:47

Rename TOperationMetrics/TOperationSpan -> TRequestMetrics/TRequestSp…

f6a019e

…an, remove TQuerySpan and TQueryMetrics, modify TClientOperationStatCollector constructor

Create TRequestObservation, add ydbClientType to avoid metrics confus…

5f8a13e

…ion, other_sql -> ydb

fix test

94cbdd0

Gazizonoki reviewed Apr 7, 2026

View reviewed changes

src/client/impl/internal/common/ydb_client_api.h Outdated Show resolved Hide resolved

src/client/impl/stats/stats.h Show resolved Hide resolved

src/client/impl/stats/stats.h Show resolved Hide resolved

maladetska added 2 commits April 8, 2026 14:34

Add db.namespace, add ExternalMetricRegistry to TClientStatCollector,…

75c777d

… make attributes freecase

fix test

0f0d655

Conversation

maladetska commented Feb 7, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌋 SLO Test Results

Uh oh!

Uh oh!

Uh oh!

Gazizonoki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gazizonoki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gazizonoki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Feb 21, 2026 •

edited

Loading