feat: capture and log non-whitelisted email recipients in staging environment#48
Open
hnccox-yard wants to merge 1 commit intomainfrom
Open
feat: capture and log non-whitelisted email recipients in staging environment#48hnccox-yard wants to merge 1 commit intomainfrom
hnccox-yard wants to merge 1 commit intomainfrom
Conversation
hnccox-yard
requested review from
a team,
Rovasch,
SimonvanWijhe,
dtakken,
ictbeheer,
mvdhoek1,
rivanuff and
robertbossaert
and removed request for
a team
|
Coverage report for commit: 9759b65 Summary - Lines: 2.49% | Methods: 3.33%🤖 comment via lucassabreu/comment-coverage-clover |
hnccox-yard
force-pushed
the
feat/catch-emails-in-staging-env
branch
9 times, most recently
from
b4907b0 to
4c9f2bb
Compare
Contributor
|
Wat is hier de use case van en is dit relevant voor alle projecten? |
hnccox-yard
force-pushed
the
feat/catch-emails-in-staging-env
branch
from
724d75c to
5e87d6f
Compare
dtakken
reviewed
Jul 7, 2025
dtakken
left a comment
dtakken
left a comment
There was a problem hiding this comment.
Vraag: Wil je errors enkel loggen (wat je niet meteen merkt) of een exception gooien (merk je wel meteen)?
hnccox-yard
force-pushed
the
feat/catch-emails-in-staging-env
branch
from
e892690 to
e917d12
Compare
ictbeheer
reviewed
Jul 7, 2025
ictbeheer
reviewed
Jul 7, 2025
ictbeheer
reviewed
Jul 7, 2025
mvdhoek1
requested changes
Jul 8, 2025
Contributor
mvdhoek1
left a comment
mvdhoek1
left a comment
There was a problem hiding this comment.
Gelieve de boel eerst opschonen, zoals de eerdere review comments ook al aangeven.
hnccox-yard
force-pushed
the
feat/catch-emails-in-staging-env
branch
3 times, most recently
from
1151093 to
5fd63ea
Compare
Author
Ik denk dat loggen voldoende is, dit is niet iets wat in Sentry hoeft te komen denk ik. |
hnccox-yard
force-pushed
the
feat/catch-emails-in-staging-env
branch
10 times, most recently
from
2346917 to
abf6ec8
Compare
hnccox-yard
force-pushed
the
feat/catch-emails-in-staging-env
branch
from
abf6ec8 to
ad8b13f
Compare
mvdhoek1
reviewed
Nov 4, 2025
| /** | ||
| * Filter wp_mail to restrict email sending in staging environment. | ||
| */ | ||
| add_filter('wp_mail', [MailHandler::class, 'filter']); |
Contributor
There was a problem hiding this comment.
Worden de IDE's ook blij van: add_filter('wp_mail', MailHandler::filter(...));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure that no emails from any staging environment are actually send out via WordPress, unless they are on the whitelist. This prevents accidental emails being send when using real data.