Closed
Conversation
…f.substrates as GeometryCollection
3 tasks
|
Just tested current Kikit 1.7.2 with Kicad 10.0.0-rc2 and it appears to be working. Only tested the backend, though. So is this pull request needed? Maybe they fixed something already in Kicad side? |
Owner
|
We just baked in the KiCAD 10 support. It took a different approach compared to this PR, hence, closing. Nevertheless, thank you for your effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
board.GetItem->board.ResolveItemzone.SetDoNotAllowCopperPour->zone.SetDoNotAllowZoneFillsself.substratesbeing aGeometryCollection(previously it was only handled in one of two cases)