Conversation
yaqwsx
requested changes
Dec 16, 2025
| import traceback | ||
| from typing import List, Optional, Tuple, Union, Callable | ||
| from kikit.defs import Layer | ||
| from kikit.typing import Box |
Owner
There was a problem hiding this comment.
Oh, I see. You renamed the file kikit.typing to kikit.kityping - why? This breaks other places where the file is imported.
| from kikit.export import gerberImpl | ||
| from kikit.export import exportSettingsGatema | ||
|
|
||
| #def collectBom(components, lscsFields, ignore): |
| if drc: | ||
| ensurePassingDrc(loadedBoard) | ||
|
|
||
| refsToIgnore = parseReferences(ignore) |
Owner
There was a problem hiding this comment.
When you are not doing assembly, I think this is not needed.
| archiveName = expandNameTemplate(nametemplate, "gerbers", loadedBoard) | ||
| shutil.make_archive(os.path.join(outputdir, archiveName), "zip", outputdir, "gerber") | ||
|
|
||
| # if not assembly: |
|
|
||
| @click.command() | ||
| @fabCommand | ||
| @click.option("--ignore", type=str, default="", help="Comma separated list of designators to exclude from SMT assembly") |
Owner
There was a problem hiding this comment.
As Gatema doesn't do assembly, why one would need an option to ignore components?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Gatema PCB fabrication option based on jlcpcb implementation