Skip to content

VCUT Comments Layer#677

Draft
gcormier wants to merge 1 commit intoyaqwsx:masterfrom
gcormier:vcut-txt-layer
Draft

VCUT Comments Layer#677
gcormier wants to merge 1 commit intoyaqwsx:masterfrom
gcormier:vcut-txt-layer

Conversation

@gcormier
Copy link

This allows the user to specify on which layer they would like VCUT text to appear. This could be a different layer from the actual cuts themselves.

TODO
It is added twice. I need help understanding the logic of the main panelize() to know how to exclude this. Line 608 of panelize is where it can possibly be added twice. Unsure if I should break out labels into a completely different function, or, try to pass in a parameter to help decide when to plot labels.

@gcormier
Copy link
Author

gcormier commented Aug 1, 2024

@yaqwsx Did you want me to contribute further on this one?

@yaqwsx
Copy link
Owner

yaqwsx commented Jan 26, 2025

Hi! Sorry for my long response time. Overall, I am in favor of specifying the text on a different layer. However, in a way, you propose it is a breaking change. If there is a workflow that changes the V-cut layer, after updating KiKit, the text will be on a different layer.

As a suitable solution I see an option to introduce layer "Inherit" which will inherit the layer from a parent element (which can be different based on the context, for V-cut text t will be the V-cut layer).

@gcormier
Copy link
Author

gcormier commented Feb 1, 2025

No problem! Life gets busy :)

Working on this one was quite a while ago and was a bit of a limit to my skills. I probably won't continue work on this PR, so we can either close or leave it open if someone else down the road wants to work on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants