Generalize correction pattern file handling#438
Open
mairas wants to merge 3 commits intoyaqwsx:masterfrom
Open
Generalize correction pattern file handling#438mairas wants to merge 3 commits intoyaqwsx:masterfrom
mairas wants to merge 3 commits intoyaqwsx:masterfrom
Conversation
Check that the number of fields is correct for each row.
The correction pattern expression is now tried against the reference, value and footprint name attributes of each footprint (in this order).
mairas
force-pushed
the
generalize_corpat
branch
from
5fd9ead to
5d3a6c7
Compare
Contributor
Author
|
Could this PR be considered for merging? At the moment I need to maintain a separate local fork to support my workflow, and it gets old soon... :-) |
Contributor
Author
|
@yaqwsx ping? |
yaqwsx
force-pushed
the
master
branch
5 times, most recently
from
63883b3 to
e0c897b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hadn't quite finished the correction pattern work so far. This PR fixes at least some of the issues: