Add support for pasting an image in the page, and a grayscale button#2
Open
AmineI wants to merge 2 commits intoyangcha:masterfrom
Open
Add support for pasting an image in the page, and a grayscale button#2AmineI wants to merge 2 commits intoyangcha:masterfrom
AmineI wants to merge 2 commits intoyangcha:masterfrom
Conversation
Using the grayscale function from MDN Web docs
Adding files like that does not fire a change event for the input, so a modification of handleImageFiles() was required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there !
I found your work quite impressive, being able to do this in browser ! So I wanted to add a few helpful additions :
Helpful when you keep screenshotting and pasting in there !
Just keep in mind that clicking somewhere on the canvas will overwrite your clipboard with the coordinates. This got me tearing my hair out, not understanding why it was not working. When I finally opened a clipboard manager, I noticed that I had coordinates in there, so not much it could paste.
Sometimes life's better in black and white, huh ?