Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/kbmate_cli/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ def convert_single(

md_path = converts_dir / f"{safe_stem}.md"
md_path.write_text(markdown_content, encoding="utf-8")

if assets_dir.exists() and not any(assets_dir.iterdir()):
assets_dir.rmdir()

typer.echo(f"Converted: {source_path} -> {md_path}")


Expand Down
45 changes: 41 additions & 4 deletions tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,21 +36,26 @@ def test_convert_lunwen_pdf():
assert result.exit_code == 0


@patch.dict("kbmate_cli.main._CONVERTERS", {".pdf": MagicMock(return_value="# mock")})
def test_bulk_convert_assets_seqname_flag():
src = FIXTURE_DIR / "eigent README CN.pdf"
with tempfile.TemporaryDirectory() as tmp:
root = Path(tmp)
pdf = root / "a.pdf"
pdf.write_text("fake")
shutil.copy2(src, root / src.name)
out = root / "out"
result = runner.invoke(app, [
"bulk-convert", "-r", str(root),
"--output-dir", str(out),
"--assets-seqname",
])
assert result.exit_code == 0
assets_dir = out / "assets" / "a"
assets_dir = out / "assets" / "eigent_README_CN"
assert assets_dir.exists()
images = sorted(assets_dir.glob("*.png"))
assert len(images) > 0
for i, img in enumerate(images, 1):
assert img.name == f"image-{i:03d}.png"
md_content = (out / "converts" / "eigent_README_CN.md").read_text()
assert f"assets/eigent_README_CN/image-001.png" in md_content


def test_convert_pdf_with_spaces_in_filename():
Expand Down Expand Up @@ -422,6 +427,38 @@ def test_bulk_convert_file_list_file_not_found_with_temp(mock_resolve, mock_hint
mock_hint.assert_called_once()


# ── Assets dir cleanup tests ──────────────────────────────────────────


@patch.dict("kbmate_cli.main._CONVERTERS", {".pdf": MagicMock(return_value="# mock\nno images")})
def test_convert_single_cleans_up_empty_assets_dir(tmp_path):
pdf = tmp_path / "test.pdf"
pdf.write_text("fake")
convert_single(pdf, tmp_path)
assert (tmp_path / "converts" / "test.md").exists()
assert not (tmp_path / "assets" / "test").exists()


@patch.dict("kbmate_cli.main._CONVERTERS", {".pdf": MagicMock(return_value="# mock\nno images")})
def test_bulk_convert_flat_cleans_up_empty_assets_dirs(tmp_path):
root = tmp_path
pdf1 = root / "a.pdf"
pdf2 = root / "b.pdf"
pdf1.write_text("fake")
pdf2.write_text("fake")

out = root / "out"
result = runner.invoke(app, [
"bulk-convert", "-r", str(root),
"--output-dir", str(out),
])
assert result.exit_code == 0
assert (out / "converts" / "a.md").exists()
assert (out / "converts" / "b.md").exists()
assert not (out / "assets" / "a").exists()
assert not (out / "assets" / "b").exists()


@patch("kbmate_cli.main.print_cleanup_hint")
@patch("kbmate_cli.main._resolve_source")
@patch.dict("kbmate_cli.main._CONVERTERS", {".pdf": MagicMock(side_effect=ValueError("convert failed"))})
Expand Down
Loading