feat: add onImageError callback for handling image load errors#339
Open
CorleoneYu wants to merge 1 commit intoyWorks:masterfrom
Open
feat: add onImageError callback for handling image load errors#339CorleoneYu wants to merge 1 commit intoyWorks:masterfrom
CorleoneYu wants to merge 1 commit intoyWorks:masterfrom
Conversation
Member
|
Nice! How about returning the image data or a promise for it? The implementation can then choose to can handle the image request and return a fallback image.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configurable onImageError callback for image loading failures
This PR adds an optional
onImageErrorcallback toSvg2PdfOptionsthat allows consumers to decide how to handle image loading failures, addressing the feedback from #338.Changes
onImageErrorcallback option toSvg2PdfOptionsinterfaceImageNodefor both image data loading and dimension retrieval failuresimageUrl,error, andelementparametersboolean:trueto interrupt rendering (throw error),falseto silently skip the imageImplementation Details
The callback is invoked in two places:
imageLoadingPromisefails (image data loading)getImageDimensionsfails (image dimension retrieval)If the callback returns
true, the error is re-thrown to interrupt the rendering process. If it returnsfalseor is not provided, the error is silently ignored and the image is skipped (maintaining backward compatibility).Usage Example
Testing