Skip to content

fix(storage): Stop updating start timestamp on job, task instance, and scheduler lease table change (fixes #145). #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sitaowang1998 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(storage): Stop updating start timestamp on job, task instance, and scheduler lease table change (fixes #145). #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49091b7
Do not update start timestamp for job, task_instance and scheduler_lease
sitaowang1998 Jun 2, 2025
e470150
Merge branch 'main' into timestamp_update
sitaowang1998 Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/spider/storage/mysql/mysql_stmt.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ std::string const cCreateSchedulerTable = R"(CREATE TABLE IF NOT EXISTS `schedul
std::string const cCreateJobTable = R"(CREATE TABLE IF NOT EXISTS jobs (
`id` BINARY(16) NOT NULL,
`client_id` BINARY(16) NOT NULL,
`creation_time` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
`creation_time` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
`state` ENUM('running', 'success', 'cancel', 'fail') NOT NULL DEFAULT 'running',
KEY (`client_id`) USING BTREE,
INDEX idx_jobs_creation_time (`creation_time`),
Expand Down Expand Up @@ -104,15 +104,15 @@ std::string const cCreateTaskDependencyTable = R"(CREATE TABLE IF NOT EXISTS `ta
std::string const cCreateTaskInstanceTable = R"(CREATE TABLE IF NOT EXISTS `task_instances` (
`id` BINARY(16) NOT NULL,
`task_id` BINARY(16) NOT NULL,
`start_time` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
`start_time` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
CONSTRAINT `instance_task_id` FOREIGN KEY (`task_id`) REFERENCES `tasks` (`id`) ON UPDATE NO ACTION ON DELETE CASCADE,
PRIMARY KEY (`id`)
))";

std::string const cCreateSchedulerLeaseTable = R"(CREATE TABLE IF NOT EXISTS `scheduler_leases` (
`scheduler_id` BINARY(16) NOT NULL,
`task_id` BINARY(16) NOT NULL,
`lease_time` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
`lease_time` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
CONSTRAINT `lease_scheduler_id` FOREIGN KEY (`scheduler_id`) REFERENCES `schedulers` (`id`) ON UPDATE NO ACTION ON DELETE CASCADE,
CONSTRAINT `lease_task_id` FOREIGN KEY (`task_id`) REFERENCES `tasks` (`id`) ON UPDATE NO ACTION ON DELETE CASCADE,
INDEX (`scheduler_id`),
Expand Down
6 changes: 3 additions & 3 deletions tools/scripts/storage/init_db.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ CREATE TABLE IF NOT EXISTS jobs
(
`id` BINARY(16) NOT NULL,
`client_id` BINARY(16) NOT NULL,
`creation_time` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
`creation_time` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
`state` ENUM ('running', 'success', 'fail', 'cancel') NOT NULL DEFAULT 'running',
KEY (`client_id`) USING BTREE,
INDEX idx_jobs_creation_time (`creation_time`),
Expand Down Expand Up @@ -103,15 +103,15 @@ CREATE TABLE IF NOT EXISTS `task_instances`
(
`id` BINARY(16) NOT NULL,
`task_id` BINARY(16) NOT NULL,
`start_time` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
`start_time` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
CONSTRAINT `instance_task_id` FOREIGN KEY (`task_id`) REFERENCES `tasks` (`id`) ON UPDATE NO ACTION ON DELETE CASCADE,
PRIMARY KEY (`id`)
);
CREATE TABLE IF NOT EXISTS `scheduler_leases`
(
`scheduler_id` BINARY(16) NOT NULL,
`task_id` BINARY(16) NOT NULL,
`lease_time` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
`lease_time` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
CONSTRAINT `lease_scheduler_id` FOREIGN KEY (`scheduler_id`) REFERENCES `schedulers` (`id`) ON UPDATE NO ACTION ON DELETE CASCADE,
CONSTRAINT `lease_task_id` FOREIGN KEY (`task_id`) REFERENCES `tasks` (`id`) ON UPDATE NO ACTION ON DELETE CASCADE,
INDEX (`scheduler_id`),
Expand Down