fix(new-webui): Add support for querying metadata from multiple datasets (fixes #1024).#1042
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is blocked by #1004 / #1050. We cannot test fix for UI, until multiple datasets can be ingested
Description
PR #868 modified the names of the metadata tables leading to issue #1024. The table names were changed, breaking the ui.
The pr is fixes the issue by first querying all datasets, then issuing a large runtime generated query that includes a subquery for each dataset, and finally combines the results using UNION ALL. The large query should be more performant than sending multiple queries for each dataset.
This is even more complicated since clp does not have datasets, so in that case, the dataset query is not sent, and the old query is used.
The solution is a bit crude, but should be fine for a limited number of datasets. I will create an issue about another solution we discussed where we add a dataset column instead of renaming the tables.
Checklist
breaking change.
Validation performed
Tested clp and clp-s(with 1 dataset). Need to wait #1004 to test multiple dataset, but it should support it
Summary by CodeRabbit
New Features
Refactor
Chores