Bump yscope clp core#1
Open
Bill-hbrhbr wants to merge 2 commits into
Open
Conversation
Summary: Bring `validation/schemas/` in sync with the trace writer. `SCHEMAS_BY_TYPE` previously mapped only `reg_trace` / `mem_trace` / `opcode_only` / `kernel_metadata`, but the writer also emits `mem_value_trace`, `mem_addr_trace`, and `tma_trace` — none of which had a schema, so `validate` / `compare` silently skipped every current trace's data records. New schemas (field sets verified against the serializers and a real trace): - `tma_trace.schema.json`: version-union — only the common fields are required; the descriptor fields are writer-variant-dependent and optional (the current writer emits `tma_param_size` + `tma_transfer_info` + `desc_addr`; older traces emit `desc_addr` + `desc_raw`, 16 hex-string qwords). Accepting both keeps the schema valid across writer versions. - `mem_value_trace.schema.json`: `ipoint:"A"`, `mem_space`, `is_load`, `access_size`, `addrs[32]`, `values[32][1..4]` (the old `mem_trace.schema.json` only had `addrs`). - `mem_addr_trace.schema.json`: `ipoint:"B"`, `addrs[32]`. `schema_loader.py` loads the three and registers them in `SCHEMAS_BY_TYPE` (`mem_trace` kept for backward compatibility); `validation/__init__.py` re-exports them. Reviewed By: wlei-llvm Differential Revision: D106872962 fbshipit-source-id: 6497b94546804b29c1d08ebbba7b1fccd2b66f15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.