Add optional parameter includeLength to encrypt/decrypt functions, to add possibility encrypt/decrypt values without length#5
Open
EgzoT wants to merge 2 commits intoxxtea:masterfrom
Open
Conversation
…ibility decrypt non string values
…ibility decrypt non string values
Member
|
Without length, the decrypt text is not correct if the encrypt data length is not a multiple of 4. |
Author
Yes, I only tested for multiples of 4. But I didn't use this for text but for Buffer data converted to Uint8Array (data from bluetooth device). So, what's the best way to convert Buffer data using these methods? |
Member
|
You don't need to modify anything. Just call encrypt and decrypt directly with Uint8Array arguments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.