Skip to content

Adds at-rule handling to CSS compression.#60

Open
msigley wants to merge 1 commit intoxwp:masterfrom
msigley:patch_20140604
Open

Adds at-rule handling to CSS compression.#60
msigley wants to merge 1 commit intoxwp:masterfrom
msigley:patch_20140604

Conversation

@msigley
Copy link

@msigley msigley commented Jun 4, 2014

Properly handles charset, namespace, and import at-rules according to:
https://developer.mozilla.org/en-US/docs/Web/CSS/At-rule

Import rules are currently just stripped out of the CSS to prevent issues in the output, but this could be improved by including the contents of the import url and compressing it.

@msigley
Copy link
Author

msigley commented Jun 4, 2014

Fixes issue #59.

@westonruter
Copy link
Contributor

@msigley this Compressor.php is actually copied from the Minify project: https://github.com/mrclay/minify/blob/master/min/lib/Minify/CSS/Compressor.php

Can you instead open a PR to apply the change to the file in that project, and we can fold it into Dependency Minification. I wouldn't want the changes to get lost the next time it gets updated.

@msigley
Copy link
Author

msigley commented Jun 4, 2014

Thanks I submitted a new pull request to the Minify project.
mrclay/minify#101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants