Skip to content

Upgrade parent 15.10 #132#138

Open
abrassat wants to merge 4 commits intoxwikisas:masterfrom
abrassat:upgrade-parent-15.10
Open

Upgrade parent 15.10 #132#138
abrassat wants to merge 4 commits intoxwikisas:masterfrom
abrassat:upgrade-parent-15.10

Conversation

@abrassat
Copy link
Copy Markdown

Issue URL

Closes #132

Changes

Description

  • Added some escapes
  • Replaced deprecated velocity API calls (like $collectionstool, $doc.getName(), $services.officemanager.getServerState(), etc..)
  • Replaced deprecated jQuery API calls

Executed Tests

Manual & Automated

  • I checked the accessibility of this change (if you don't know what this is about or how to do it, leave this unchecked and don't worry)

Expected merging strategy

  • Prefers squash: Yes

@abrassat abrassat self-assigned this Mar 25, 2026
* Update licensor version
@abrassat abrassat requested a review from rbancescu March 26, 2026 10:48
Comment thread ui/src/main/resources/FileManager/FileTagCloud.xml
Comment thread ui/src/main/resources/FileManager/FileTagCloud.xml
Comment thread ui/src/main/resources/FileManager/FileTagCloud.xml
Copy link
Copy Markdown

@rbancescu rbancescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also check the escaping inside FileManager.FileManagerSheet. I know it’s not related to the parent upgrade, but I think it would be better to fix this as well.

Also, I see that an error is occurring from DriveSheet (Tested on Chrome and Firefox).
image

@abrassat
Copy link
Copy Markdown
Author

abrassat commented Apr 3, 2026

Also, I see that an error is occurring from DriveSheet (Tested on Chrome and Firefox).

Leaving this comment so I can debug it later. The cause is this line is undefined for some reason:

var url = new XWiki.Document('!page', '!space', '!wiki').getRestURL('objects/XWiki.XWikiUsers/0')

I'll have to try more to reproduce locally.

Update: This happens when there exists a file which was saved by superadmin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade parent to 15.10

2 participants