Skip to content

Fix function comments based on best practices from Effective Go #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodeLingoTeam wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix function comments based on best practices from Effective Go #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion loadbalancer/lbutils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func createCertPool(backendConfig *config.BackendConfig) (*x509.CertPool, error)
return pool, nil
}

// NewLoadBalancer instantiates a load balancer based on the named backend configuration. Backend
// NewBackendLoadBalancer instantiates a load balancer based on the named backend configuration. Backend
// names are scoped to routes, thus the route is given to ensure the correct backend is returned
// if multiple backend definitions with the same name are given.
func NewBackendLoadBalancer(backendName string) (*BackendLoadBalancer, error) {
Expand Down
2 changes: 1 addition & 1 deletion service/health.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func (hcc *HealthCheckContext) HealthHandler() http.HandlerFunc {
}
}

//Return current health status
//GetHealthStatus returns current health status
func (hcc *HealthCheckContext) GetHealthStatus() *HealthResponse {

hr := &HealthResponse{
Expand Down