Refactor TTS processing to use interval loop #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webwaifu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| currentTTSAudio.currentTime = 0; | ||
| setTTSPlayingState(false); | ||
| ttsInputVolume = 0; | ||
| } |
There was a problem hiding this comment.
Bug: Inconsistent Animation Handling Across TTS Providers
In speakWithEdgeTTS(), when stopping any currently playing TTS audio, the function calls setTTSPlayingState(false) but does not call stopTalkingAnimationForTTS(). However, speakWithAzure() does call stopTalkingAnimationForTTS() when stopping previous audio (line 5917). This inconsistency can leave the talking animation in an active state when switching between TTS providers, causing the animation to continue playing even when no audio is playing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_6901c9b8d7c483308e3fddb58338307b