Skip to content

refactor: remove local formatBytes wrappers #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xsploit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove local formatBytes wrappers #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions service-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ class OllamaService {
const enhancedModels = (data.models || []).map(model => ({
...model,
displayName: model.name,
size: this.formatBytes(model.size),
size: SharedUtils.formatBytes(model.size),
capabilities: this.getModelCapabilities(model),
family: model.details?.family || 'unknown',
parameterSize: model.details?.parameter_size || 'unknown'
Expand Down Expand Up @@ -263,11 +263,6 @@ class OllamaService {
return ModelUtils.isThinkingModel(modelName);
}

formatBytes(bytes) {
// Use shared utility to eliminate code duplication
return SharedUtils.formatBytes(bytes);
}

async pullModel(modelName, progressCallback = null) {
try {
const response = await fetch(`${this.baseURL}/api/pull`, {
Expand Down
7 changes: 1 addition & 6 deletions settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ class SideLlamaSettings {
}

const modelElements = models.map(model => {
const memoryUsage = this.formatBytes(model.size_vram || model.size || 0);
const memoryUsage = SharedUtils.formatBytes(model.size_vram || model.size || 0);
const duration = model.expires_at ? this.formatDuration(new Date(model.expires_at) - new Date()) : 'Indefinite';

return `
Expand All @@ -477,11 +477,6 @@ class SideLlamaSettings {
this.runningModelsList.innerHTML = modelElements;
}

formatBytes(bytes) {
// Use shared utility to eliminate code duplication
return SharedUtils.formatBytes(bytes);
}

formatDuration(ms) {
if (ms < 0) return 'Expired';
const minutes = Math.floor(ms / 60000);
Expand Down