Skip to content

refactor: reuse escaped attachment filename #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xsploit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: reuse escaped attachment filename #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions sidepanel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1422,18 +1422,17 @@ class SideLlamaChat {
previewDiv.dataset.attachmentId = attachment.id;

let content = '';
const safeFilename = this.escapeHtml(attachment.filename);
if (attachment.type.startsWith('image/')) {
// Validate that dataUrl is safe (must be data: URL for images)
const safeDataUrl = this.sanitizeDataUrl(attachment.dataUrl);
const safeFilename = this.escapeHtml(attachment.filename);
content = `<img src="${safeDataUrl}" alt="${safeFilename}" title="${safeFilename}">`;
} else if (attachment.isTextFile && attachment.content) {
// Show text content preview
const previewText = attachment.content.length > 100
? attachment.content.substring(0, 100) + '...'
const previewText = attachment.content.length > 100
? attachment.content.substring(0, 100) + '...'
: attachment.content;
const icon = this.getFileIcon(attachment.type, attachment.filename);
const safeFilename = this.escapeHtml(attachment.filename);
content = `
<div class="text-file-preview" title="${safeFilename}">
<div class="file-header">
Expand All @@ -1446,7 +1445,6 @@ class SideLlamaChat {
} else {
// File icon for other files
const icon = this.getFileIcon(attachment.type, attachment.filename);
const safeFilename = this.escapeHtml(attachment.filename);
content = `<div class="attachment-icon" title="${safeFilename}">${icon}<br><small>${safeFilename}</small></div>`;
}

Expand Down