Add license for bibliographic data and make Dockerfile more robust#1222
Add license for bibliographic data and make Dockerfile more robust#1222Flowdalic wants to merge 2 commits intoxsf:masterfrom
Conversation
|
|
||
| WORKDIR /src | ||
| RUN OUTDIR=/var/www/html/extensions/ make -j$NCORES $TARGETS | ||
| RUN --mount=target=/xeps make -C /xeps -j$NCORES $TARGETS OUTDIR=/var/www/html/extensions |
There was a problem hiding this comment.
This implies that I cannot do git operations (like switching branches) while the build is running, without corrupting the result, right?
That would be a blocker.
There was a problem hiding this comment.
You could do git operations, but those will be immediately be reflected in the container with all the consequences that may have.
I am not sure how why this makes this approach as non suitable? How often do you perform git actions while a build is running? Regardless of the existence of a docker layer used for the build or not. You wouldn't run cmake .. && ninja and simultaneously switch the git branch, would you?
And in addition, this changes simplifies the Dockerfile enormously, we do not longer have to explicitly COPY stuff into the docker build context.
This reverts commit 59b2a5c.
Instead of copying individual files into /src, we simply bind mount the build context, which is typically the XEPs repo, and invoke 'make' with the givne targets on that.
Flowdalic
force-pushed
the
refs-license
branch
from
dd12b26 to
5bc830b
Compare
2 participants
Second iteration after #1220