implemented conditional cookie only when user is logged in, fixes #274#379
Open
MartinHinz wants to merge 1 commit intomasterfrom
Open
implemented conditional cookie only when user is logged in, fixes #274#379MartinHinz wants to merge 1 commit intomasterfrom
MartinHinz wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented @joeroe’s suggestion to remove cookies for users who are not logged in. This should address the key issues highlighted in #274 for most common scenarios. Are there any potential edge cases or concerns I might have overlooked?