Conversation
Closed
joeroe
reviewed
Jun 7, 2024
Contributor
There was a problem hiding this comment.
At first glance, this does raise a couple of issues:
- #8
- Up until now we've avoided hard-coding (apart from measurement, period, typochronology_unit, and ecochronological_unit, which was a workaround for the nested API response). Since this lists them all explicitly as expected columns, we would need to update the R package whenever they change in the API response, and any workflows relying on previous versions of the package would break.
Author
|
Thanks for pointing this out! I am happy to take back these two adjustments, as the following reasons were originally behind them:
I will produce another update to the PR in a moment. However, this solution still does not create a completely flat structure, as the periods and the associated columns are still nested, even when the references are not nested! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced tidyverse functionality (map) with more base R functions. Code is not as nice as before, but significantly faster.