Open
Conversation
Owner
|
Hey @stefanhayden, thanks for opening a PR! The lack of stability in the setState function was an unfortunate mistake I made in some of the initial versions of useUndoable. It was, in fact, something I wanted to address in version 6, which I have a draft PR for now (although, I haven't been able to get back to it for some time). Since v6 is a significant refactor, I would want to include these changes there (more precisely, I'll be replacing the definition of setState with the one you have here). I'll keep this PR open until I get those changes integrated, and give you an update at that time. Thank you again for taking the time to improve the code here! You rock! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. Thanks for all the hard work you put in here.
I was a bit surprised the setState function was not stable. In react when using
useStatethat function is always stable. This repo, which does try and mirror that pattern, has made a different choice. I was looking at past conversations and I don't 100% understand why, but no worries.I was wondering if you could also export a stable function like the one I have in this PR? I'm sure the
static_setStateis helpful to some but I don't see a reason to not also provide a more common stable function. I've been using it in my own project and I don't know of any downsides.again, thanks for your hard work and I hope this kind of addition is considered.