improve nix cache action & add binaries to cache#3020
Conversation
|
Claude finished @insipx's task —— View job PR Review - January 28, 2026 at 23:47 UTCReview Checklist:
SummaryThis PR improves the Nix caching infrastructure and adds CLI binaries ( Critical Issues1. Package name mismatch in
|
Replace CI Nix installer with
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
==========================================
- Coverage 74.01% 73.91% -0.10%
==========================================
Files 447 447
Lines 54990 54990
==========================================
- Hits 40701 40648 -53
- Misses 14289 14342 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2d6e0d8 to
797a63f
Compare
797a63f to
aff7cbe
Compare
a34166d to
832fa55
Compare
b4f655c to
875b45e
Compare
c9978e5 to
92ead07
Compare
b79007f to
ae7ade3
Compare
ae7ade3 to
e4c3340
Compare
e4c3340 to
1027701
Compare
1027701 to
ced673b
Compare
| # Bindings (excluding wasm - only for wasm32 target) | ||
| "bindings/mobile", | ||
| "bindings/node", | ||
| "bindings/[!wasm]*", |
There was a problem hiding this comment.
🟡 Medium
The pattern [!wasm]* is a character class negation, meaning "not any single character in {w,a,s,m}". Since mobile starts with m, it won't match. Consider using a different approach to exclude only wasm, such as explicitly listing bindings/mobile and bindings/node.
| "bindings/[!wasm]*", | |
| "bindings/mobile", | |
| "bindings/node", |
🚀 Want me to fix this? Reply ex: "fix it for me".
this adds the
xdbgandxmtp_clibinaries to https://app.cachix.org/cache/xmtp#pins. building the binaries off main (withnix build .#xdbg) will download the already-built artifact rather than rebuildadds a description to every crate
still need to verify they work (and fixes the broken fh cache on main that's been there for a while) but my
nix flake updateis broken b/c of github outage