Skip to content

Update Protos#2839

Closed
github-actions[bot] wants to merge 2 commits intomainfrom
nightly-proto
Closed

Update Protos#2839
github-actions[bot] wants to merge 2 commits intomainfrom
nightly-proto

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

  • Nightly Proto Update

Auto-generated by create-pull-request

@github-actions github-actions Bot requested a review from a team as a code owner November 24, 2025 10:11
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Nov 24, 2025

How to use the Graphite Merge Queue

Add the label mergequeue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Nov 24, 2025

Regenerate proto files to reorder type declarations

Regenerates all protobuf-derived Rust source files in crates/xmtp_proto/src/gen/. The changes are purely structural reshuffles of type and enum definitions within each file — no fields, signatures, or semantics are modified.

Macroscope summarized 6c8cb9c.

@fbac fbac closed this Nov 24, 2025
@fbac fbac reopened this Nov 24, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.96%. Comparing base (9a8d47f) to head (6c8cb9c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2839      +/-   ##
==========================================
+ Coverage   82.93%   82.96%   +0.02%     
==========================================
  Files         376      376              
  Lines       50896    50896              
==========================================
+ Hits        42213    42227      +14     
+ Misses       8683     8669      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot force-pushed the nightly-proto branch 2 times, most recently from 682ec6d to ba264dc Compare December 22, 2025 10:11
@github-actions github-actions Bot force-pushed the nightly-proto branch 2 times, most recently from 668a9ac to 482d499 Compare January 26, 2026 10:12
Copy link
Copy Markdown
Contributor

@macroscopeapp macroscopeapp Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-evaluating approvability for 0fa5fbf

@github-actions github-actions Bot force-pushed the nightly-proto branch 2 times, most recently from 794a000 to 7bde377 Compare February 16, 2026 10:29
@github-actions github-actions Bot requested a review from a team as a code owner February 16, 2026 10:29
@github-actions github-actions Bot force-pushed the nightly-proto branch 2 times, most recently from 0e14184 to 0fa5fbf Compare March 2, 2026 10:27
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Mar 9, 2026

Approvability

Verdict: Needs human review

These are auto-generated protobuf reorganizations with no changes to types or fields. All modified files fall under the protocol-sdk code owners, and the author is not a designated owner, so I’d recommend a human verify the reorganization.

No code changes detected at 6c8cb9c. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

@claude
Copy link
Copy Markdown

claude Bot commented Mar 23, 2026

Claude finished @github-actions[bot]'s task —— View job


Code Review Complete

Review Date: March 23, 2026, 23:16 UTC

Summary: This PR contains auto-generated protobuf reorganizations with no semantic changes. The modifications are purely structural reorderings of type and enum definitions within the generated Rust files.

Analysis:

I reviewed the changes across all 5 modified files in crates/xmtp_proto/src/gen/. The changes follow a consistent pattern:

  • Type definitions (structs, enums, impls) are moved from the end of files to the beginning
  • No field names, types, tags, or method signatures have been modified
  • All protobuf tag numbers remain unchanged (critical for wire compatibility)
  • The binary descriptor file size decreased from 341KB to 316KB (likely due to reorganization optimization)

Examples from the diff:

  • xmtp.message_api.v1.rs: Token and AuthData structs moved from end (lines 721-771) to beginning (lines 2-51)
  • xmtp.message_contents.rs: Ciphertext and SignedEciesCiphertext moved from lines 223-320 to lines 72-169

Findings:

No issues identified - This is a benign code reorganization with:

  • Zero semantic changes
  • No security concerns
  • No performance impact
  • No bug risks
  • Wire format compatibility maintained

Note: As Macroscope correctly identified, these are structural-only changes. The fact that 1170 lines were added and 1170 deleted confirms this is pure reorganization with no net code change.

Recommendation: Safe to merge. This is routine protobuf regeneration maintenance.


@insipx insipx closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants