Fix publish_outcomes and publish_errors_total metrics#97
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 81.22% 80.89% -0.33%
==========================================
Files 30 30
Lines 1731 1738 +7
==========================================
Hits 1406 1406
- Misses 296 303 +7
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/comcast-cl/xmidt/issues/5734
and possibly https://github.com/comcast-cl/xmidt/issues/5736
outcome.String()to the log statement so the string value of the outcome is logged, not just the corresponding iota constantpublish_errors_totalwhen the publisher receives an error from attempting to produce a messagepublish_outcomesbefore thehandleOutcomecall (could thehandleOutcomecall be cancelling the context before the metric is updated?)