Skip to content

refactor outbound sender to allow for multiple modes of dispatch #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
piccione99 wants to merge 9 commits into
base: main
Choose a base branch
from

unit tests

47cbc87
Select commit
Loading
Failed to load commit list.
Draft

refactor outbound sender to allow for multiple modes of dispatch #614

unit tests
47cbc87
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 17, 2025 in 1s

55.73% (+1.83%) compared to d496c94

View this Pull Request on Codecov

55.73% (+1.83%) compared to d496c94

Details

Codecov Report

❌ Patch coverage is 64.01180% with 244 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.73%. Comparing base (d496c94) to head (47cbc87).

Files with missing lines Patch % Lines
internal/kinesis/kinesis.go 41.74% 114 Missing and 6 partials ⚠️
webhook_dispatcher.go 72.62% 40 Missing and 9 partials ⚠️
webhook_outbound_sender.go 72.27% 22 Missing and 6 partials ⚠️
main.go 0.00% 21 Missing ⚠️
stream_dispatcher.go 80.30% 10 Missing and 3 partials ⚠️
internal/stream/sender.go 67.85% 6 Missing and 3 partials ⚠️
stream_outbound_sender.go 89.28% 2 Missing and 1 partial ⚠️
outboundSender.go 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   53.89%   55.73%   +1.83%     
==========================================
  Files           9       16       +7     
  Lines        1334     1830     +496     
==========================================
+ Hits          719     1020     +301     
- Misses        574      749     +175     
- Partials       41       61      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov