fix(arch): extend slice-verb fitness allowlist for event + reaction#25
Open
xmap wants to merge 1 commit into
Open
fix(arch): extend slice-verb fitness allowlist for event + reaction#25xmap wants to merge 1 commit into
xmap wants to merge 1 commit into
Conversation
…action domain nouns PR #22 (slice-a-reaction-split, commit 9357801) landed the `agent.dismiss_event_in_reaction` operator slice without extending the Phase 5 slice-verb fitness allowlist. The slice uses two real Agent-BC domain nouns: - `Reaction` is the Agent BC's term for subscriber classes (RunDebriefer, CautionDrafter) — they react to events from other BCs. See the slice's command.py docstring for the full "Reaction's bookmark" framing. - `event` is the unit the Reaction processes; the operator-recovery slice advances the bookmark past a poison event. Adds both to `_DOMAIN_NOUN_ALLOWLIST` in test_slice_verb_names_subject.py with the same per-entry comment style as the existing reasoning / entry / permission entries. Origin/main's `test_slice_dir_carries_subject` was failing post-PR-#22 merge; this fix unblocks ANY downstream PR built on origin/main.
3 tasks
Coverage report
This PR does not seem to contain any modification to coverable code. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_slice_dir_carries_subject[agent.dismiss_event_in_reaction]is currently failing.935780130) landed thedismiss_event_in_reactionslice without extending the Phase 5 slice-verb fitness allowlist.eventandreactionto_DOMAIN_NOUN_ALLOWLIST, with per-entry comments matching the existing reasoning / entry / permission style.Why these two are real domain nouns
command.pydocstring frames it as "advance the Reaction's bookmark past a poison event."Blast radius
test_slice_verb_names_subject.py, all arch fitness green).Test plan
eventorreactionaccidentally passing the allowlist (the two strings are distinct enough that false positives are unlikely).🤖 Generated with Claude Code