Support for more SMS validity period formats#38
Conversation
This is to accommodate other TP-VP formats that can take a variable amount of bytes.
Define ValidityPeriod as a type alias to RelativeValidityPeriod for backward compatibility.
* Implement enhanced relative VP format support * Implement enhanced "relative integer" VP format support where "relative integer" refers to the unnamed format denoted by 0b010 in 3GPP TS 23.040 9.2.3.12.3. * Leave enhanced "relative semi-octet" format unsupported where "relative semi-octet" refers to the unnamed format denoted by 0b011 in 3GPP TS 23.040 9.2.3.12.3.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 36.13% 34.76% -1.38%
==========================================
Files 18 21 +3
Lines 1605 1795 +190
==========================================
+ Hits 580 624 +44
- Misses 940 1080 +140
- Partials 85 91 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@xlab a gentle reminder if you might take a look at this at some point. |
|
@ah9142 apologies for the delay, I am actually happy to accept pull requests and new features there. Having more validity period options is a great feat, and thanks for keeping compatibility. I don't have unfortunately hardware means to validate this, but if it works for you that's cool! |
|
No problem. I haven't been working on anything |
Hello.
If you are interested in accepting pull requests,
I implemented encode/decode support for the absolute SMS validity period format
as well as support for 2/3 enhanced SMS validity period formats.
I think the main thing you might want to check is the public
Messagestruct.New parameter fields
AbsoluteVPandEnhancedVPfor the new formats were added.This way of adding them is simple and preserves backwards compatibility.
However, if you have any objections, then feel free to propose another way and let's see how to go forwards.