Allow PowerJS to start when PowerShell profiles take a long time to load#13
Open
IsaacUtah1379 wants to merge 2 commits intoxipid:masterfrom
Open
Allow PowerJS to start when PowerShell profiles take a long time to load#13IsaacUtah1379 wants to merge 2 commits intoxipid:masterfrom
IsaacUtah1379 wants to merge 2 commits intoxipid:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #12, PowerShell will write a message to
stderrif loading the PowerShell profiles takes longer than 500 ms, causing an error to be thrown whenPowerJSis instantiated. This pull request allows the instantiation ofPowerJSeven when the profiles take more than 500 ms to load by altering the statement checking#readerrto instead check a copy of#readerrthat has had all matches to the RegEx/Loading personal and system profiles took \d+ms\./greplaced with the empty string and extraneous whitespace trimmed away.Closes #12.