Use region dimensions in SAD and ME#3097
Closed
shssoichiro wants to merge 2 commits intoxiph:masterfrom
Closed
Conversation
fc03f98 to
e14fa64
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3097 +/- ##
==========================================
- Coverage 86.81% 86.80% -0.02%
==========================================
Files 83 83
Lines 33104 33101 -3
==========================================
- Hits 28740 28734 -6
- Misses 4364 4367 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e14fa64 to
c2c7a7a
Compare
Collaborator
|
It seems that some of the assumptions do not hold in certain circumstances. To investigate, I would revert the parts where width and height parameters are removed and assert that they match the region dimensions. |
Collaborator
Author
|
This is going to be rather painful to debug given that it only seems to be failing on x64 Macos. Why that is, I have no clue... I'll fix it up when I have a moment. |
This avoids having to re-check bounds every time we perform SAD, as the region knows its own size. It also may save 2 usize's being passed around during ME. To enforce this, we also remove the w and h parameters from everywhere. This is part of a series of commits authored by @maj160 to improve performance of rav1e.
98994ef to
bc171d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids having to re-check bounds every time we perform SAD, as the region knows its own size. It also may save 2 usize's being passed around during ME. To enforce this, we also remove the w and h parameters from everywhere.
This is part of a series of commits authored by @maj160 to improve performance of rav1e.