Skip to content

runtime: preserve FuncForPC names for function values#1924

Draft
cpunion wants to merge 1 commit into
xgo-dev:mainfrom
cpunion:codex/goroot-fixedbugs-funcforpc-names
Draft

runtime: preserve FuncForPC names for function values#1924
cpunion wants to merge 1 commit into
xgo-dev:mainfrom
cpunion:codex/goroot-fixedbugs-funcforpc-names

Conversation

@cpunion
Copy link
Copy Markdown
Collaborator

@cpunion cpunion commented May 24, 2026

Summary

  • add runtime FuncForPC name lookup backed by debug symbol info
  • keep command-line function-value wrappers distinct for FuncForPC so folded functions still report separate names
  • cover the issue58300 pattern in test/go and remove issue58300/issue58300b goroot xfails

Tests

  • go test ./test/go -run TestRuntimeFuncForPCNamesWithLLGo -count=1
  • go test ./test/go -count=1
  • go test ./test/goroot -count=1 -run TestGoRootRunCases -args -goroot $(go env GOROOT) -dirs fixedbugs -case '^fixedbugs/issue58300(b)?.go$' -directive-mode=ci -xfail /tmp/llgo-no-xfail.yaml -run-timeout=2m
  • go test ./test/goroot -count=1 -run TestGoRootRunCases -args -goroot $(go env GOROOT) -dirs fixedbugs -case '^fixedbugs/issue58300(b)?.go$' -directive-mode=ci -run-timeout=2m
  • go test ./ssa -count=1
  • go test ./cl -run 'TestRunAndTestFromTestgo|TestRunAndTestFromTestrt|TestRunAndTestFromTestdata' -count=1
  • git diff --check

@cpunion cpunion force-pushed the codex/goroot-fixedbugs-funcforpc-names branch from 3b9293f to 97d74a8 Compare May 24, 2026 14:32
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 81.25000% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cl/compile.go 65.00% 3 Missing and 4 partials ⚠️
ssa/interface.go 66.66% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants