Skip to content

test/goroot: fix bug449 runoutput handling#1923

Draft
cpunion wants to merge 1 commit into
xgo-dev:mainfrom
cpunion:codex/goroot-fixedbugs-runoutput-bug449
Draft

test/goroot: fix bug449 runoutput handling#1923
cpunion wants to merge 1 commit into
xgo-dev:mainfrom
cpunion:codex/goroot-fixedbugs-runoutput-bug449

Conversation

@cpunion
Copy link
Copy Markdown
Collaborator

@cpunion cpunion commented May 24, 2026

Summary

  • generate runoutput temporary source once with baseline Go, then build/run that generated file with Go and LLGo
  • count generated-source compilation against build timeout instead of run timeout
  • add runner coverage proving LLGo is not used to run the runoutput generator
  • remove fixed bug449 runoutput xfail/timeout entries

Local verification

  • go test ./test/goroot -run 'TestRunOutputCaseGeneratesWithBaselineGoOnly|TestRunGeneratedProgramUsesProvidedTimeout|TestEnsureModuleWorkspace|TestSplitSourceFiles' -count=1 -v\n- go test ./test/goroot -count=1\n- go test ./test/goroot -run TestGoRootRunCases -count=1 -timeout 20m -v -args -goroot "$(go env GOROOT)" -dirs fixedbugs -case '^fixedbugs/bug449\.go$' -directive-mode ci -xfail /tmp/llgo-goroot-empty-xfail.yaml -progress 30s\n- bash dev/test_goroot.sh /Users/lijie/sdk/go1.25.0 -- -dirs fixedbugs -case '^fixedbugs/bug449\.go$' -directive-mode ci -xfail /tmp/llgo-goroot-empty-xfail.yaml -progress 30s\n- bash dev/test_goroot.sh /Users/lijie/sdk/go1.26.0 -- -dirs fixedbugs -case '^fixedbugs/bug449\.go$' -directive-mode ci -xfail /tmp/llgo-goroot-empty-xfail.yaml -progress 30s\n- go test ./test/goroot -run TestGoRootRunCases -count=1 -timeout 20m -v -args -goroot "$(go env GOROOT)" -dirs fixedbugs -case '^fixedbugs/bug449\.go$' -directive-mode ci -progress 30s

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants