Skip to content

fix recursive named pointer types#1922

Draft
cpunion wants to merge 1 commit into
xgo-dev:mainfrom
cpunion:codex/goroot-fixedbugs-recursive-types
Draft

fix recursive named pointer types#1922
cpunion wants to merge 1 commit into
xgo-dev:mainfrom
cpunion:codex/goroot-fixedbugs-recursive-types

Conversation

@cpunion
Copy link
Copy Markdown
Collaborator

@cpunion cpunion commented May 24, 2026

Summary

  • avoid eager LLVM element type expansion for opaque pointers
  • cover recursive and mutually recursive named type literals in test/go
  • remove the goroot xfail for fixedbugs/bug336.go

Verification

  • go test ./test/go -count=1
  • LLGO_ROOT="/Users/lijie/source/goplus/llgo-wt-goroot-fixedbugs-recursive-types" /tmp/llgo-recursive-types-fixed test ./test/go -run TestRecursiveNamedTypeLiterals -count=1
  • go test ./test/goroot -run TestGoRootRunCases -count=1 -timeout 30m -args -goroot "/opt/homebrew/Cellar/go@1.24/1.24.11/libexec" -dirs fixedbugs -case '^fixedbugs/bug336.go$' -xfail /tmp/llgo-empty-xfail-does-not-exist.yaml -run-timeout 2m -build-timeout 5m
  • go test ./ssa -count=1
  • go test ./ssa -run TestPointerTypeDoesNotExpandRecursiveNamedElement -count=1
  • go test ./cl -run '^TestRunAndTestFromTestgo$/^typerecur$' -count=1

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants