Skip to content

reflect: fix type metadata and MakeFunc results#1916

Draft
cpunion wants to merge 1 commit into
xgo-dev:mainfrom
cpunion:codex/goroot-fixedbugs-reflect-coverage
Draft

reflect: fix type metadata and MakeFunc results#1916
cpunion wants to merge 1 commit into
xgo-dev:mainfrom
cpunion:codex/goroot-fixedbugs-reflect-coverage

Conversation

@cpunion
Copy link
Copy Markdown
Collaborator

@cpunion cpunion commented May 24, 2026

Summary

  • fix reflected PkgPath metadata for command-line-arguments fields and unsafe.Pointer
  • skip writes to blank struct fields while preserving initializer side effects
  • validate reflect.MakeFunc result counts/types and pass MakeFunc func values correctly through reflect.Value.Call

Coverage

  • adds test/go llgo probe for PkgPath, blank fields, MakeFunc error panics, and MakeFunc bool funcs passed through reflect.Value.Call
  • removes xfail entries for fixedbugs issue10332, issue28748, issue31546, issue44830, issue52788, and issue52788a

Tests

  • go test ./test/go -run TestReflectTypeMetadataMakeFuncProbe -count=1
  • go test ./test/goroot -run TestGoRoot -count=1 -timeout=8m -args -goroot /opt/homebrew/Cellar/go@1.25/1.25.7_1/libexec -llgo /tmp/llgo-reflect-coverage -dirs fixedbugs -directive-mode ci -case "fixedbugs/(issue10332|issue28748|issue31546|issue44830|issue52788|issue52788a)\.go$" -run-timeout 90s
  • go test ./test/goroot ... same case filter with -xfail /tmp/llgo-no-xfail.yaml on Go 1.24.11, Go 1.25.7, and Go 1.26.0

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ssa/abitype.go 50.00% 2 Missing and 2 partials ⚠️
cl/compile.go 66.66% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants