Skip to content

fix(build): default non-constant untyped shifts#1911

Draft
cpunion wants to merge 1 commit into
xgo-dev:mainfrom
cpunion:codex/goroot-shift-coverage
Draft

fix(build): default non-constant untyped shifts#1911
cpunion wants to merge 1 commit into
xgo-dev:mainfrom
cpunion:codex/goroot-shift-coverage

Conversation

@cpunion
Copy link
Copy Markdown
Collaborator

@cpunion cpunion commented May 24, 2026

Summary

  • default non-constant untyped basic expressions before go/ssa build so shift-derived parent expressions do not fail sanity checks
  • add stable test/go coverage for fixedbugs/issue12133.go and fixedbugs/issue15175.go semantics
  • remove the covered goroot xfails for darwin/arm64 and linux/amd64

Tests

  • go test ./test/goroot -run TestGoRootRunCases -count=1 -args -goroot /opt/homebrew/Cellar/go@1.24/1.24.11/libexec -dirs fixedbugs -case '^(fixedbugs/issue12133.go|fixedbugs/issue15175.go)$'
  • go test ./test/go -count=1
  • go test ./internal/build -count=1
  • /tmp/llgo-shift test ./test/go

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants