fix maymorestack gcflag hook instrumentation#1910
Draft
cpunion wants to merge 1 commit into
Draft
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-gcflags=-d=maymorestack=...and carry the hook into the llgo build config.test/goCLI coverage and remove only the coveredmaymorestack.goGOROOT xfails.Coverage
Covered:
test/gobuilds and runs a temporary program with-gcflags=-d=maymorestack=main.mayMoreStackand checks the hook count.maymorestack.gopasses locally for Go 1.24.11, 1.25.0, and 1.26.0.-dforms.Not covered / intentionally out of scope:
Tests
go test ./cmd/internal/flags -count=1go test ./cmd/internal/build -count=1go test ./cl -count=1go test ./test/go -count=1go test ./test/goroot -run TestGoRootRunCases -count=1 -timeout 20m -args -goroot /Users/lijie/sdk/go1.24.11 -dirs . -case '^maymorestack\\.go$' -directive-mode ci -xfail /tmp/llgo-empty-xfail.yaml -run-timeout 45s -build-timeout 5mgo test ./test/goroot -run TestGoRootRunCases -count=1 -timeout 20m -args -goroot /Users/lijie/sdk/go1.25.0 -dirs . -case '^maymorestack\\.go$' -directive-mode ci -xfail /tmp/llgo-empty-xfail.yaml -run-timeout 45s -build-timeout 5mgo test ./test/goroot -run TestGoRootRunCases -count=1 -timeout 20m -args -goroot /Users/lijie/sdk/go1.26.0 -dirs . -case '^maymorestack\\.go$' -directive-mode ci -xfail /tmp/llgo-empty-xfail.yaml -run-timeout 45s -build-timeout 5mgo test ./test/goroot -run TestGoRootRunCases -count=1 -timeout 20m -args -goroot /Users/lijie/sdk/go1.24.11 -dirs . -case '^maymorestack\\.go$' -directive-mode ci -run-timeout 45s -build-timeout 5mgo test ./test/goroot -run TestGoRootRunCases -count=1 -timeout 20m -args -goroot /Users/lijie/sdk/go1.25.0 -dirs . -case '^maymorestack\\.go$' -directive-mode ci -run-timeout 45s -build-timeout 5mgo test ./test/goroot -run TestGoRootRunCases -count=1 -timeout 20m -args -goroot /Users/lijie/sdk/go1.26.0 -dirs . -case '^maymorestack\\.go$' -directive-mode ci -run-timeout 45s -build-timeout 5mgo test ./cmd/internal/... -count=1go test ./ssa -count=1go test ./internal/build -count=1