ssa: handle recursive pointer type names#1909
Draft
cpunion wants to merge 2 commits into
Draft
Conversation
Collaborator
Author
|
Update after expanding Peano coverage:
Local validation passed for focused goroot Peano + issue4316, |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type Number *Numbertest/gocoverage that runs a recursive named pointer type through llgo, including a 4096-deep Peano construction/count matchingfixedbugs/issue4316.gopeano.goandfixedbugs/issue4316.gogoroot xfails for darwin/arm64 and linux/amd64Scope
Tests
go test ./test/goroot -count=1 -run TestGoRootRunCases -timeout 10m -args -goroot "$(go env GOROOT)" -dirs fixedbugs -case '^fixedbugs/issue4316\.go$' -xfail /dev/null -run-timeout 2mgo test ./test/goroot -count=1 -run TestGoRootRunCases -timeout 10m -args -goroot "$(go env GOROOT)" -dirs . -case '^peano\.go$' -xfail /dev/null -run-timeout 2mgo test ./test/goroot -count=1 -run TestGoRootRunCases -timeout 15m -args -goroot "$(go env GOROOT)" -dirs .,fixedbugs -case '^(peano\.go|fixedbugs/issue4316\.go)$' -xfail /dev/null -run-timeout 2mgo test ./test/go -run TestRecursivePointerTypeBuilds -count=1go test ./test/go -count=1go test ./ssa -count=1go test ./cl -list .go test ./cl -run TestRunAndTestFromTestgo -count=1 -timeout 5mLocal test notes
go test ./cl -count=1was also attempted locally and was terminated after 428s without a Peano/named-pointer failure.go test ./cl -run 'TestRunAndTestFromTestgo|TestRunAndTestFromTestrt' -count=1 -timeout 5mtimed out inTestRunAndTestFromTestrt/index; this is outside the recursive named pointer / Peano scope.