Open
Conversation
…tup for MultiFormatPipeline The MultiFormatPipeline is disabled for the time being
Member
|
Thanks @woweh - I haven't had the chance to test and merge this yet, but it's in the works.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a C# guy, just starting with JS... any comments and guidance is welcome.
I've refactored
convert.js, moved the code into smaller functions, updated theviewer.htmland add some additional information to the ReadMe.See:
https://github.com/woweh/xeokit-model-conversion-tests/tree/AddMultiFormatPipeline
Tested on Win11, WSL2, Ubuntu 22.04.2 LTS.
Best Regards
Wolfgang