Feature/handle slashes #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially since the unescape nil casts to nil and one cannot gsub on nil. Raising an `NoMethodError: undefined method `gsub!' for nil:NilClass` exception.
* feature/handle_nil_values_hstore: Avoid errors on values that cannot be `gsub!ed` or `strip!ed`.
Otherwise we fail on strings like "foo\".
berkes
force-pushed
the
feature/handle_slashes
branch
from
b4c4b56 to
63fa786
Compare
This is inspired by https://github.com/softa/activerecord-postgres-hstore/blob/master/lib/activerecord-postgres-hstore/hash.rb And it should solve some ugly escaping bugs
berkes
force-pushed
the
feature/handle_slashes
branch
from
63fa786 to
bf2a1a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Follows after previous PR to avoid merge conflicts.
This avoids errors on strings such as "foo", by escaping them.