transformations: (convert-pdl-to-pdl-interp) generate_rewriter

[jumerckx]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 98.59155% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.04%. Comparing base (f9cd7b8) to head (57da4f5).
⚠️ Report is 228 commits behind head on main.

Files with missing lines	Patch %	Lines
...transforms/convert_pdl_to_pdl_interp/conversion.py	98.59%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5530   +/-   ##
=======================================
  Coverage   86.03%   86.04%           
=======================================
  Files         391      391           
  Lines       55784    55855   +71     
  Branches     6417     6438   +21     
=======================================
+ Hits        47995    48061   +66     
- Misses       6263     6266    +3     
- Partials     1526     1528    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[superlopuh]

I'm just looking at the coverage, and I'm wondering whether we want to update some existing tests that use the private methods to instead use this public helper?

[jumerckx]

yeah that makes sense, will do this before merging?

[superlopuh]

Yep that would be ideal.

[superlopuh]

Thank you for updating the tests! There's still quite a lot of lines without coverage in the new function, and I'm not sure how important this is. Let's chat tomorrow about it?

[jumerckx]

I mainly wasn't thorough enough, I think. Let me fix that and see

[jumerckx]

I think I finally got there

[superlopuh]

Thank you!