transformations: (riscv-lower-parallel-mov) remove unnecessary casts#5523
Closed
anominos wants to merge 6 commits intoxdslproject:mainfrom
Closed
transformations: (riscv-lower-parallel-mov) remove unnecessary casts#5523anominos wants to merge 6 commits intoxdslproject:mainfrom
anominos wants to merge 6 commits intoxdslproject:mainfrom
Conversation
Contributor
Author
|
depends on #5512 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5523 +/- ##
=======================================
Coverage 86.02% 86.02%
=======================================
Files 392 392
Lines 55813 55815 +2
Branches 6419 6420 +1
=======================================
+ Hits 48012 48014 +2
Misses 6269 6269
Partials 1532 1532 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anominos
force-pushed
the
riscv-parallel-move-lowering/refactor/remove-cast
branch
2 times, most recently
from
06d8ee4 to
2f0789b
Compare
- unify the two different casts - makes is_allocated check nicer
anominos
force-pushed
the
riscv-parallel-move-lowering/refactor/remove-cast
branch
from
2f0789b to
1fe1cf3
Compare
Contributor
Author
|
Closing in favour of #5512 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there are some assignments at the start of the function for type casting. However, these casts have been split by an if block.
This PR moves all type casting assignments to the top of the function to unify the assignments.