Skip to content

dialects: (riscv) add shift right immediate canonicalization #5518

Merged
superlopuh merged 2 commits intoxdslproject:mainfrom
nmjfry:shift-right-imm
Jan 8, 2026
Merged

dialects: (riscv) add shift right immediate canonicalization #5518
superlopuh merged 2 commits intoxdslproject:mainfrom
nmjfry:shift-right-imm

Conversation

@nmjfry
Copy link
Copy Markdown
Contributor

@nmjfry nmjfry commented Dec 29, 2025

No description provided.

@nmjfry nmjfry changed the title dialects: (riscv) add shift right immediate constant folding dialects: (riscv) add shift right immediate canonicalization Dec 29, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.02%. Comparing base (f43c7a5) to head (6cf3307).
⚠️ Report is 246 commits behind head on main.

Files with missing lines Patch % Lines
xdsl/transforms/canonicalization_patterns/riscv.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5518      +/-   ##
==========================================
+ Coverage   85.99%   86.02%   +0.02%     
==========================================
  Files         389      392       +3     
  Lines       55708    55819     +111     
  Branches     6411     6420       +9     
==========================================
+ Hits        47906    48018     +112     
- Misses       6268     6269       +1     
+ Partials     1534     1532       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nmjfry nmjfry marked this pull request as ready for review December 29, 2025 11:48
Copy link
Copy Markdown
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking great! This is one of the suggestions in the docs/index.md file, can you please replace it with a new one, one that isn't already implemented?

@nmjfry
Copy link
Copy Markdown
Contributor Author

nmjfry commented Dec 30, 2025

Code is looking great! This is one of the suggestions in the docs/index.md file, can you please replace it with a new one, one that isn't already implemented?

Thank you!
Of course! Although I didn't use the suggestion from index.md - so I can leave it for the next person?

@superlopuh
Copy link
Copy Markdown
Member

I would prefer it if you changed it, as I'd like the state of that file to be consistent with the rest of the project, if that makes sense. If we merge this PR as-is, the next person might attempt to add a pattern that's already in the project, which would be a pretty bad experience.

@superlopuh superlopuh added the dialects Changes on the dialects label Dec 30, 2025
@nmjfry
Copy link
Copy Markdown
Contributor Author

nmjfry commented Dec 30, 2025

I would prefer it if you changed it, as I'd like the state of that file to be consistent with the rest of the project, if that makes sense. If we merge this PR as-is, the next person might attempt to add a pattern that's already in the project, which would be a pretty bad experience.

Ahh yes makes sense :) thanks!!

@nmjfry
Copy link
Copy Markdown
Contributor Author

nmjfry commented Jan 7, 2026

I would prefer it if you changed it, as I'd like the state of that file to be consistent with the rest of the project, if that makes sense. If we merge this PR as-is, the next person might attempt to add a pattern that's already in the project, which would be a pretty bad experience.

Ok I updated the docs, might want to check this isn't already implemented as well. I could only see it for and and or but not the immediate versions

@superlopuh
Copy link
Copy Markdown
Member

This is great! Thank you

@superlopuh superlopuh merged commit 573d224 into xdslproject:main Jan 8, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dialects Changes on the dialects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants