dialects: (riscv) add shift right immediate canonicalization #5518
dialects: (riscv) add shift right immediate canonicalization #5518superlopuh merged 2 commits intoxdslproject:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5518 +/- ##
==========================================
+ Coverage 85.99% 86.02% +0.02%
==========================================
Files 389 392 +3
Lines 55708 55819 +111
Branches 6411 6420 +9
==========================================
+ Hits 47906 48018 +112
- Misses 6268 6269 +1
+ Partials 1534 1532 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
superlopuh
left a comment
There was a problem hiding this comment.
Code is looking great! This is one of the suggestions in the docs/index.md file, can you please replace it with a new one, one that isn't already implemented?
Thank you! |
|
I would prefer it if you changed it, as I'd like the state of that file to be consistent with the rest of the project, if that makes sense. If we merge this PR as-is, the next person might attempt to add a pattern that's already in the project, which would be a pretty bad experience. |
Ahh yes makes sense :) thanks!! |
Ok I updated the docs, might want to check this isn't already implemented as well. I could only see it for and and or but not the immediate versions |
|
This is great! Thank you |
No description provided.