Use an equal check on the referent rather than on the string#73
Open
burdoto wants to merge 1 commit intoxdrop:developfrom
burdoto:referentfix
Open
Use an equal check on the referent rather than on the string#73burdoto wants to merge 1 commit intoxdrop:developfrom burdoto:referentfix
burdoto wants to merge 1 commit intoxdrop:developfrom
burdoto:referentfix
Conversation
This can come in handy in a case where the user has implemented a custom equals implementation that may return TRUE even if the resulting string is not the same, and it seems more logical to rather check the actual referent instead of the string representation. Note that this check will never occur if not this and the to-be-compared-Result are not both on the same string referent state. (&& ends if left statement is false already)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can come in handy in a case where the user has implemented a custom equals implementation that may return TRUE even if the resulting string is not the same, and it seems more logical to rather check the actual referent instead of the string representation.
Note that this check will never occur if not this and the to-be-compared-Result are not both on the same string referent state. (&& ends if left statement is false already)