Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contexts/VideoContext:Clip및ContextType,VideoContext정의app/Video:/videopage에서 확인 가능. Context 주입 및 DB pseudo로 생성components/VideoController: 주입 받은 context 가운데setCurrClip사용하여 Player에 props로 넘겨주게끔 함. 다음 영상으로 넘어가는 로직도 여기에 처리하면 되지 않을까 생각함. 참고로currClip, setCurrClip은 url string만 받는 것이 아니라 아예Clip객체를 전부 받는 것으로 수정했습니다.components/Player: 받은 url에 따라 video 재생하는 pure component. 여기도 context로 받을 수 있지만 일단 props로 처리해 두었음. 뭐가 더 좋을지는 만들면서 생각해 보겠습니다.