feat(workflow): mastermind-style-deep writes a developer portrait, not count-bullets#23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the
mastermind-style-deepskill from a flat list of grepped counts into a grounded developer portrait.Why
The first version produced 8 isolated count-bullets — useful, but it (a) asserted preferences like "iterators over loops" without counting the alternative, and (b) credited things a linter forces (e.g.
///on every fn under#![deny(missing_docs)]) as personal signature. It read like a lint report, not a description of a person.What
The skill now instructs the agent to write a portrait organized by the dimensions of how someone actually develops: design & problem-solving, code shape, comments (do they write them at all?), tests (parametrized or one-off?), optimization (measured or not?), what they pay attention to, and commit voice. Prose per dimension, every claim tied to a tell.
New guards, all addressing real gaps:
904 iterator calls vs 185 for-loops).rustfmt.toml/#![deny(missing_docs)]/clippy.toml/ CI lint steps; a tool-forced trait is a measured rule, not a signature, and is excluded.Testing
python scripts/validate.pyclean (20 artifacts). Demonstrated on the mmcg crate — the portrait correctly distinguished personal habits (heavy doc-comments, nomissing_docslint) from enforced ones (clippy-D warningsin CI), and grounded every dimension in counts.