Open
Conversation
kaanolgu
requested changes
Feb 12, 2026
Collaborator
kaanolgu
left a comment
There was a problem hiding this comment.
Initial check for poisson_fft and poisson_fft_cuda
3b6afdc to
57a0a33
Compare
Collaborator
|
LGTM! (If anything else pops up, we can always address it in a follow-up PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For review I suggest looking at couple of source files that you're familiar with and check if the comments are OK (in terms of accuracy, verbosity).
Alternatively you could do the following:
pip install fordx3d2/docsand then runford ford.mdx3d2/docs/doc/index.htmlin a browserClose #247