Fix build of GMP 6.3.0 on older versions of GCC, such as GCC 9. #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit c145e3c resolves the issue for GCC 15. However, omitting parameter names in function definitions is a C23 feature. This thus causes configuration to fail with a GCC 9 host compiler. Signed-off-by: Sam Nazarko <email@samnazarko.co.uk>
Collaborator
|
Hi Sam, we probbaly need this on the Piers branch before we bring it onto Omega. |
Contributor
Author
|
Actually I don’t think we to, because Piers has new minimum C++ requirements anyway and effectively forces the necessity for new tool chains. |
Collaborator
|
Gotcha, will merge this so. |
phunkyfish
approved these changes
Dec 28, 2025
Member
|
Just to verify, this change isn't needed for Piers? |
Contributor
Author
|
No because build requirements already mitigate this
On 19 Jan 2026, at 00:50, Garrett Brown ***@***.***> wrote:
[https://avatars.githubusercontent.com/u/531482?s=20&v=4]garbear left a comment (xbmc/inputstream.ffmpegdirect#361)<#361 (comment)>
Just to verify, this change isn't needed for Piers?
—
Reply to this email directly, view it on GitHub<#361 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHDWLAJ4KZMNA3L67TZPJL4HQS55AVCNFSM6AAAAACP4EITCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONRVHE3TINRTGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit c145e3c resolves the issue for GCC 15.
However, omitting parameter names in function definitions is a C23 feature. This thus causes configuration to fail with a GCC 9 host compiler.